AIETraceOps.cpp

Go to the documentation of this file.

//===- AIETraceOps.cpp ------------------------------------------*- C++ -*-===//
//
// Copyright (C) 2025 Advanced Micro Devices, Inc.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// Implementation of AIE trace operations
//===----------------------------------------------------------------------===//
 
#include "aie/Dialect/AIE/IR/AIEDialect.h"
 
#include "mlir/IR/OpImplementation.h"
#include "mlir/IR/SymbolTable.h"
#include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/StringRef.h"
 
using namespace mlir;
using namespace xilinx;
using namespace xilinx::AIE;
 
//===----------------------------------------------------------------------===//
// TraceEventAttr Helper Methods
//===----------------------------------------------------------------------===//
 
std::string TraceEventAttr::getEventName() const {
  if (auto strAttr = llvm::dyn_cast<StringAttr>(getValue())) {
    // If the string is fully qualified (contains '::'), extract just the name
    StringRef strValue = strAttr.getValue();
    size_t pos = strValue.find("::");
    if (pos != StringRef::npos) {
      return strValue.substr(pos + 2).str();
    }
    return strAttr.getValue().str();
  }
 
  // Fallback: unexpected attribute kind.
  return "";
}
 
bool TraceEventAttr::isStringAttr() const {
  return llvm::isa<StringAttr>(getValue());
}
 
std::optional<int64_t> TraceEventAttr::getEnumValue() const {
  if (auto intAttr = llvm::dyn_cast<IntegerAttr>(getValue())) {
    return intAttr.getInt();
  }
  // String values don't have enum values - they're event names
  return std::nullopt;
}
 
//===----------------------------------------------------------------------===//
// Tile Type Validation Helper
//===----------------------------------------------------------------------===//
 
static bool isValidEventForTile(TileLike tile, Attribute eventAttr,
                                const AIETargetModel &targetModel) {
  // Determine tile type from TileLike interface
  bool isShimTile = tile.isShimTile();
  bool isMemTile = tile.isMemTile();
  bool isCoreTile = tile.isCoreTile();
  AIEArch arch = targetModel.getTargetArch();
 
  // If eventAttr is a TraceEventAttr, extract the inner attribute
  Attribute innerAttr = eventAttr;
  if (auto traceEvent = llvm::dyn_cast<TraceEventAttr>(eventAttr)) {
    innerAttr = traceEvent.getValue();
  }
 
  // Enum-qualified strings (e.g. "CoreEventAIE2P::INSTR_EVENT_0") encode both
  // architecture and tile type in the prefix.  We validate the prefix against
  // the device arch and tile kind here.  Plain strings (no "::") are deferred
  // to lowering where the event database is available.
  //
  // NOTE: The parser stores enum events as strings rather than typed
  // I32EnumAttrs because AIE2 and AIE2P enums share identical integer values,
  // making isa<> checks ambiguous across architectures.
  if (auto strAttr = llvm::dyn_cast<StringAttr>(innerAttr)) {
    StringRef val = strAttr.getValue();
    size_t sep = val.find("::");
    if (sep == StringRef::npos)
      return true; // plain string — validated during lowering
 
    StringRef prefix = val.substr(0, sep);
 
    // Map (arch, tileKind) → set of allowed prefixes.
    if (isCoreTile) {
      switch (arch) {
      case AIEArch::AIE1:
        return prefix == "CoreEventAIE" || prefix == "MemEventAIE";
      case AIEArch::AIE2:
        return prefix == "CoreEventAIE2" || prefix == "MemEventAIE2";
      case AIEArch::AIE2p:
        return prefix == "CoreEventAIE2P" || prefix == "MemEventAIE2P";
      default:
        return false;
      }
    }
    if (isMemTile) {
      switch (arch) {
      case AIEArch::AIE2:
        return prefix == "MemTileEventAIE2";
      case AIEArch::AIE2p:
        return prefix == "MemTileEventAIE2P";
      default:
        return false;
      }
    }
    if (isShimTile) {
      switch (arch) {
      case AIEArch::AIE1:
        return prefix == "ShimTileEventAIE";
      case AIEArch::AIE2:
        return prefix == "ShimTileEventAIE2";
      case AIEArch::AIE2p:
        return prefix == "ShimTileEventAIE2P";
      default:
        return false;
      }
    }
    return false;
  }
 
  return false;
}
 
//===----------------------------------------------------------------------===//
// TraceOp
//===----------------------------------------------------------------------===//
 
void TraceOp::getAsmResultNames(
    function_ref<void(Value, StringRef)> setNameFn) {
  // No results for this operation
}
 
LogicalResult TraceOp::verify() {
  // Count trace events
  int eventCount = 0;
  for (auto &op : getBody().getOps()) {
    if (isa<TraceEventOp>(op)) {
      eventCount++;
    }
  }
 
  // Check max 8 events
  if (eventCount > 8) {
    return emitOpError("trace unit supports maximum 8 events, got ")
           << eventCount;
  }
 
  // Verify tile operand is a TileOp or LogicalTileOp
  if (!llvm::dyn_cast<TileLike>(getTile().getDefiningOp())) {
    return emitOpError("tile operand must be a TileOp or LogicalTileOp");
  }
 
  // Track combo/edge slot usage within this trace
  llvm::DenseSet<uint32_t> comboSlots;
  llvm::DenseSet<uint32_t> edgeSlots;
 
  for (auto &op : getBody().getOps()) {
    if (auto comboOp = dyn_cast<TraceComboEventOp>(op)) {
      uint32_t slot = comboOp.getSlot();
      if (!comboSlots.insert(slot).second) {
        return comboOp.emitOpError("combo event slot ")
               << slot << " already in use in this trace";
      }
    } else if (auto edgeOp = dyn_cast<TraceEdgeEventOp>(op)) {
      uint32_t slot = edgeOp.getSlot();
      if (!edgeSlots.insert(slot).second) {
        return edgeOp.emitOpError("edge detection slot ")
               << slot << " already in use in this trace";
      }
    }
  }
 
  return success();
}
 
//===----------------------------------------------------------------------===//
// Helper function for parsing event values (string or typed enum)
// Made available in xilinx::AIE namespace for reuse in AIEDialect.cpp
//===----------------------------------------------------------------------===//
 
ParseResult xilinx::AIE::parseTraceEvent(AsmParser &parser, Attribute &result) {
  MLIRContext *ctx = parser.getContext();
 
  // Try to parse as string first
  std::string strValue;
  if (succeeded(parser.parseOptionalString(&strValue))) {
    result = StringAttr::get(ctx, strValue);
    return success();
  }
 
  // Try to parse as enum (EnumType::VALUE)
  StringRef enumTypeName;
  llvm::SMLoc loc = parser.getCurrentLocation();
 
  if (failed(parser.parseKeyword(&enumTypeName))) {
    return parser.emitError(loc, "expected string or enum event");
  }
 
  if (failed(parser.parseColon()) || failed(parser.parseColon())) {
    return parser.emitError(loc, "expected '::' after enum type name");
  }
 
  StringRef caseName;
  if (failed(parser.parseKeyword(&caseName))) {
    return parser.emitError(parser.getCurrentLocation(),
                            "expected enum case name");
  }
  // Store as a qualified string ("EnumType::CaseName") rather than a typed
  // I32EnumAttr because different architecture enums share identical integer
  // values, making isa<> checks ambiguous.  The enum prefix is validated
  // against the device architecture in isValidEventForTile().
 
  // Define a helper struct for enum validation
  struct EnumValidator {
    StringRef name;
    std::function<bool(StringRef)> symbolizer;
  };
 
  // Table of supported enum types and their symbolizer functions
  static const EnumValidator validators[] = {
      // AIE2 event enums
      {"CoreEventAIE2",
       [](StringRef s) { return symbolizeCoreEventAIE2(s).has_value(); }},
      {"MemEventAIE2",
       [](StringRef s) {
         auto result = symbolizeMemEventAIE2(s);
         return result.has_value();
       }},
      {"MemTileEventAIE2",
       [](StringRef s) {
         auto result = symbolizeMemTileEventAIE2(s);
         return result.has_value();
       }},
      {"ShimTileEventAIE2",
       [](StringRef s) {
         auto result = symbolizeShimTileEventAIE2(s);
         return result.has_value();
       }},
      // AIE event enums
      {"CoreEventAIE",
       [](StringRef s) {
         auto result = symbolizeCoreEventAIE(s);
         return result.has_value();
       }},
      {"MemEventAIE",
       [](StringRef s) {
         auto result = symbolizeMemEventAIE(s);
         return result.has_value();
       }},
      {"ShimTileEventAIE",
       [](StringRef s) {
         auto result = symbolizeShimTileEventAIE(s);
         return result.has_value();
       }},
      // AIE2P event enums
      {"CoreEventAIE2P",
       [](StringRef s) {
         auto result = symbolizeCoreEventAIE2P(s);
         return result.has_value();
       }},
      {"MemEventAIE2P",
       [](StringRef s) {
         auto result = symbolizeMemEventAIE2P(s);
         return result.has_value();
       }},
      {"MemTileEventAIE2P",
       [](StringRef s) {
         auto result = symbolizeMemTileEventAIE2P(s);
         return result.has_value();
       }},
      {"ShimTileEventAIE2P",
       [](StringRef s) {
         auto result = symbolizeShimTileEventAIE2P(s);
         return result.has_value();
       }},
  };
 
  // Look up and validate the enum type
  for (const auto &validator : validators) {
    if (enumTypeName != validator.name)
      continue;
    if (!validator.symbolizer(caseName))
      return parser.emitError(loc, "unknown ")
             << enumTypeName << " value: " << caseName;
    result = StringAttr::get(ctx, enumTypeName + "::" + caseName);
    return success();
  }
 
  return parser.emitError(loc, "unknown event enum type: ") << enumTypeName;
}
 
void xilinx::AIE::printTraceEventEnum(AsmPrinter &printer, Attribute attr) {
  if (auto traceAttr = llvm::dyn_cast<TraceEventAttr>(attr)) {
    printTraceEventEnum(printer, traceAttr.getValue());
    return;
  }
  if (auto strAttr = llvm::dyn_cast<StringAttr>(attr)) {
    // If string contains "::" (enum format), print without quotes
    if (strAttr.getValue().contains("::")) {
      printer << strAttr.getValue();
      return;
    }
    printer << "\"" << strAttr.getValue() << "\"";
  }
  if (auto intAttr = llvm::dyn_cast<IntegerAttr>(attr)) {
    printer << intAttr.getInt();
    return;
  }
}
 
//===----------------------------------------------------------------------===//
// TraceEventOp
//===----------------------------------------------------------------------===//
 
LogicalResult TraceEventOp::verify() {
  // Get event name/value
  auto eventAttr = getEvent();
 
  // Basic validation - event should not be empty
  std::string eventName = eventAttr.getEventName();
  if (eventName.empty()) {
    return emitOpError("event name cannot be empty");
  }
 
  // Validate event type matches tile type
  auto trace = (*this)->getParentOfType<TraceOp>();
  if (!trace) {
    return emitOpError("must be nested in aie.trace");
  }
 
  auto tileLike = dyn_cast<TileLike>(trace.getTile().getDefiningOp());
  if (!tileLike) {
    return emitOpError("trace tile must be a TileOp or LogicalTileOp");
  }
 
  auto device = trace->getParentOfType<DeviceOp>();
  const auto &targetModel = device.getTargetModel();
 
  if (!isValidEventForTile(tileLike, eventAttr.getValue(), targetModel)) {
    std::string tileTypeStr;
    if (tileLike.isCoreTile())
      tileTypeStr = "core tile";
    else if (tileLike.isMemTile())
      tileTypeStr = "mem tile";
    else
      tileTypeStr = "shim tile";
 
    // Use the full string value (including enum prefix) for clarity.
    std::string fullEventName;
    if (auto strAttr = llvm::dyn_cast<StringAttr>(eventAttr.getValue()))
      fullEventName = strAttr.getValue().str();
    else
      fullEventName = eventName;
 
    auto col = tileLike.tryGetCol();
    auto row = tileLike.tryGetRow();
    auto fmtCoord = [](std::optional<int> v) -> std::string {
      return v ? std::to_string(*v) : "?";
    };
    return emitOpError("event '")
           << fullEventName << "' is not valid for " << tileTypeStr << " ("
           << stringifyAIEArch(targetModel.getTargetArch()) << ") at ("
           << fmtCoord(col) << ", " << fmtCoord(row) << ")";
  }
 
  return success();
}
 
//===----------------------------------------------------------------------===//
// TracePacketOp
//===----------------------------------------------------------------------===//
 
LogicalResult TracePacketOp::verify() {
  // Range is enforced by the Confined constraint in TableGen when id is
  // present; when absent, -aie-insert-trace-flows assigns one in valid
  // range from the (col, row) order over active trace tiles.
  if (auto id = getId()) {
    if (*id < 1 || *id > 31)
      return emitOpError("packet ID must be in range [1, 31], got ") << *id;
  }
  return success();
}
 
//===----------------------------------------------------------------------===//
// TracePortOp
//===----------------------------------------------------------------------===//
 
LogicalResult TracePortOp::verify() {
  // Get parent trace and tile
  auto trace = (*this)->getParentOfType<TraceOp>();
  if (!trace) {
    return emitOpError("must be nested in aie.trace");
  }
 
  auto tileLike = dyn_cast<TileLike>(trace.getTile().getDefiningOp());
  if (!tileLike) {
    return emitOpError("trace tile must be a TileOp or LogicalTileOp");
  }
 
  // Get target model
  auto device = trace->getParentOfType<DeviceOp>();
  const auto &targetModel = device.getTargetModel();
 
  // Convert DMAChannelDir to master flag: S2MM=master, MM2S=slave
  bool isMaster = (getDirection() == DMAChannelDir::S2MM);
 
  // Verify port is valid for this tile (only when placed with known col/row)
  auto col = tileLike.tryGetCol();
  auto row = tileLike.tryGetRow();
  if (col && row) {
    if (!targetModel
             .getStreamSwitchPortIndex(*col, *row, getPort(), getChannel(),
                                       isMaster)
             .has_value()) {
      return emitOpError("invalid stream switch port configuration for tile (")
             << *col << ", " << *row << ")";
    }
  }
 
  // Check for duplicate slots within same trace
  for (auto &op : trace.getBody().getOps()) {
    if (auto otherPort = dyn_cast<TracePortOp>(op)) {
      if (otherPort != *this && otherPort.getSlot() == getSlot()) {
        return emitOpError("duplicate port slot ")
               << getSlot() << " in trace " << trace.getSymName();
      }
    }
  }
 
  return success();
}
 
//===----------------------------------------------------------------------===//
// TraceStartEventOp
//===----------------------------------------------------------------------===//
 
LogicalResult TraceStartEventOp::verify() {
  // Must have either broadcast or event, but not both
  bool hasBroadcast = getBroadcast().has_value();
  bool hasEvent = getEvent().has_value();
 
  if (!hasBroadcast && !hasEvent) {
    return emitOpError("must specify either broadcast or event");
  }
 
  if (hasBroadcast && hasEvent) {
    return emitOpError("cannot specify both broadcast and event");
  }
 
  return success();
}
 
//===----------------------------------------------------------------------===//
// TraceStopEventOp
//===----------------------------------------------------------------------===//
 
LogicalResult TraceStopEventOp::verify() {
  // Must have either broadcast or event, but not both
  bool hasBroadcast = getBroadcast().has_value();
  bool hasEvent = getEvent().has_value();
 
  if (!hasBroadcast && !hasEvent) {
    return emitOpError("must specify either broadcast or event");
  }
 
  if (hasBroadcast && hasEvent) {
    return emitOpError("cannot specify both broadcast and event");
  }
 
  return success();
}
 
//===----------------------------------------------------------------------===//
// TraceStartEventOp and TraceStopEventOp
//===----------------------------------------------------------------------===//
 
void TraceStartEventOp::print(OpAsmPrinter &p) {
  if (auto broadcast = getBroadcast()) {
    p << " broadcast = " << broadcast.value();
  }
  if (auto event = getEvent()) {
    p << " event = <";
    printTraceEventEnum(p, event->getValue());
    p << ">";
  }
  p.printOptionalAttrDict((*this)->getAttrs(),
                          /*elidedAttrs=*/{"broadcast", "event"});
}
 
ParseResult TraceStartEventOp::parse(OpAsmParser &parser,
                                     OperationState &result) {
  // Parse optional broadcast
  if (succeeded(parser.parseOptionalKeyword("broadcast"))) {
    IntegerAttr broadcast;
    if (parser.parseEqual() ||
        parser.parseAttribute(broadcast, parser.getBuilder().getI32Type(),
                              "broadcast", result.attributes))
      return failure();
  }
 
  // Parse optional event
  if (succeeded(parser.parseOptionalKeyword("event"))) {
    if (parser.parseEqual() || parser.parseLess())
      return failure();
 
    Attribute innerValue;
    if (failed(parseTraceEvent(parser, innerValue)))
      return failure();
 
    auto traceEvent = TraceEventAttr::get(parser.getContext(), innerValue);
    result.attributes.set("event", traceEvent);
 
    if (parser.parseGreater())
      return failure();
  }
 
  if (parser.parseOptionalAttrDict(result.attributes))
    return failure();
 
  return success();
}
 
void TraceStopEventOp::print(OpAsmPrinter &p) {
  if (auto broadcast = getBroadcast()) {
    p << " broadcast = " << broadcast.value();
  }
  if (auto event = getEvent()) {
    p << " event = <";
    printTraceEventEnum(p, event->getValue());
    p << ">";
  }
  p.printOptionalAttrDict((*this)->getAttrs(),
                          /*elidedAttrs=*/{"broadcast", "event"});
}
 
ParseResult TraceStopEventOp::parse(OpAsmParser &parser,
                                    OperationState &result) {
  // Parse optional broadcast
  if (succeeded(parser.parseOptionalKeyword("broadcast"))) {
    IntegerAttr broadcast;
    if (parser.parseEqual() ||
        parser.parseAttribute(broadcast, parser.getBuilder().getI32Type(),
                              "broadcast", result.attributes))
      return failure();
  }
 
  // Parse optional event
  if (succeeded(parser.parseOptionalKeyword("event"))) {
    if (parser.parseEqual() || parser.parseLess())
      return failure();
 
    Attribute innerValue;
    if (failed(parseTraceEvent(parser, innerValue)))
      return failure();
 
    auto traceEvent = TraceEventAttr::get(parser.getContext(), innerValue);
    result.attributes.set("event", traceEvent);
 
    if (parser.parseGreater())
      return failure();
  }
 
  if (parser.parseOptionalAttrDict(result.attributes))
    return failure();
 
  return success();
}
 
//===----------------------------------------------------------------------===//
// TraceComboEventOp
//===----------------------------------------------------------------------===//
 
LogicalResult TraceComboEventOp::verify() {
  uint32_t slot = getSlot();
 
  // Check slot is valid (0, 1, or 2)
  if (slot > 2) {
    return emitOpError("combo event slot must be 0, 1, or 2, got ") << slot;
  }
 
  // Get parent trace and tile for validation
  auto trace = (*this)->getParentOfType<TraceOp>();
  if (!trace) {
    return emitOpError("must be nested in aie.trace");
  }
 
  auto tileLike = dyn_cast<TileLike>(trace.getTile().getDefiningOp());
  if (!tileLike) {
    return emitOpError("trace tile must be a TileOp or LogicalTileOp");
  }
 
  // Validate event types match tile
  auto device = trace->getParentOfType<DeviceOp>();
  const auto &targetModel = device.getTargetModel();
 
  if (!isValidEventForTile(tileLike, getEventA().getValue(), targetModel)) {
    return emitOpError("eventA is not valid for this tile type");
  }
  if (!isValidEventForTile(tileLike, getEventB().getValue(), targetModel)) {
    return emitOpError("eventB is not valid for this tile type");
  }
 
  // Validate event selection based on slot
  std::string eventAName = getEventA().getEventName();
  std::string eventBName = getEventB().getEventName();
 
  if (slot == 0) {
    // Combo 0: should not use eventC/D or combo results
    if (eventAName.find("COMBO_EVENT") != std::string::npos ||
        eventBName.find("COMBO_EVENT") != std::string::npos) {
      return emitOpError("combo slot 0 should use regular events, not "
                         "COMBO_EVENT_* (uses eventA/B)");
    }
  } else if (slot == 1) {
    // Combo 1: should not use combo results
    if (eventAName.find("COMBO_EVENT") != std::string::npos ||
        eventBName.find("COMBO_EVENT") != std::string::npos) {
      return emitOpError("combo slot 1 should use regular events, not "
                         "COMBO_EVENT_* (uses eventC/D)");
    }
  } else if (slot == 2) {
    // Combo 2 is hierarchical - must use COMBO_EVENT_0 and COMBO_EVENT_1
    if (eventAName != "COMBO_EVENT_0") {
      return emitOpError("combo slot 2 first event must be COMBO_EVENT_0 "
                         "(hierarchical), got ")
             << eventAName;
    }
    if (eventBName != "COMBO_EVENT_1") {
      return emitOpError("combo slot 2 second event must be COMBO_EVENT_1 "
                         "(hierarchical), got ")
             << eventBName;
    }
  }
 
  return success();
}
 
//===----------------------------------------------------------------------===//
// TraceEdgeEventOp
//===----------------------------------------------------------------------===//
 
LogicalResult TraceEdgeEventOp::verify() {
  uint32_t slot = getSlot();
 
  // Check slot is valid (0 or 1)
  if (slot > 1) {
    return emitOpError("edge detection slot must be 0 or 1, got ") << slot;
  }
 
  // Get parent trace and tile for validation
  auto trace = (*this)->getParentOfType<TraceOp>();
  if (!trace) {
    return emitOpError("must be nested in aie.trace");
  }
 
  auto tileLike = dyn_cast<TileLike>(trace.getTile().getDefiningOp());
  if (!tileLike) {
    return emitOpError("trace tile must be a TileOp or LogicalTileOp");
  }
 
  // Validate event type matches tile
  auto device = trace->getParentOfType<DeviceOp>();
  const auto &targetModel = device.getTargetModel();
 
  if (!isValidEventForTile(tileLike, getEvent().getValue(), targetModel)) {
    return emitOpError("event is not valid for this tile type");
  }
 
  // Edge events should not be other edge/combo events
  std::string eventName = getEvent().getEventName();
  if (eventName.find("EDGE_DETECTION_EVENT") != std::string::npos) {
    return emitOpError("edge detection source should be a regular event, not "
                       "another EDGE_DETECTION_EVENT");
  }
  if (eventName.find("COMBO_EVENT") != std::string::npos) {
    return emitOpError("edge detection source should be a regular event, not "
                       "a COMBO_EVENT (combo events can be used but may have "
                       "unexpected behavior)");
  }
 
  return success();
}
 
void TraceEdgeEventOp::print(OpAsmPrinter &p) {
  p << "<" << getSlot() << "> event = <";
  printTraceEventEnum(p, getEvent().getValue());
  p << "> trigger = " << getTrigger();
  p.printOptionalAttrDict((*this)->getAttrs(),
                          /*elidedAttrs=*/{"slot", "event", "trigger"});
}
 
ParseResult TraceEdgeEventOp::parse(OpAsmParser &parser,
                                    OperationState &result) {
  IntegerAttr slot;
  Attribute eventValue;
  EdgeTriggerAttr trigger;
 
  if (parser.parseLess() ||
      parser.parseAttribute(slot, parser.getBuilder().getI32Type(), "slot",
                            result.attributes) ||
      parser.parseGreater() || parser.parseKeyword("event") ||
      parser.parseEqual() || parser.parseLess())
    return failure();
 
  // Parse event value (string or enum)
  if (failed(parseTraceEvent(parser, eventValue)))
    return failure();
 
  auto event = TraceEventAttr::get(parser.getContext(), eventValue);
  result.attributes.set("event", event);
 
  if (parser.parseGreater() || parser.parseKeyword("trigger") ||
      parser.parseEqual())
    return failure();
 
  // Parse trigger as keyword (RISING, FALLING, BOTH)
  StringRef triggerStr;
  if (failed(parser.parseKeyword(&triggerStr)))
    return failure();
 
  auto triggerEnum = symbolizeEdgeTrigger(triggerStr);
  if (!triggerEnum) {
    return parser.emitError(parser.getCurrentLocation(),
                            "unknown edge trigger: ")
           << triggerStr;
  }
  trigger = EdgeTriggerAttr::get(parser.getContext(), *triggerEnum);
  result.attributes.set("trigger", trigger);
 
  if (parser.parseOptionalAttrDict(result.attributes))
    return failure();
 
  return success();
}
 
//===----------------------------------------------------------------------===//
// TraceHostConfigOp
//===----------------------------------------------------------------------===//
 
LogicalResult TraceHostConfigOp::verify() {
  // Reusing the last output buffer for trace data only works with a single
  // shim destination (the trace bytes are appended to one buffer).
  if (getReuseOutputBuffer()) {
    if (getRouting() != TraceShimRouting::Single) {
      return emitOpError("reuse_output_buffer (append trace after last tensor) "
                         "only works with single shim destination strategy "
                         "(routing=single)");
    }
  }
 
  // Validate buffer_size is positive
  if (getBufferSize() <= 0) {
    return emitOpError("buffer_size must be positive");
  }
 
  // Validate Shim col id
  if (getEgressShimCol() < 0) {
    return emitOpError("egress_shim_col must be >= 0");
  }
 
  return success();
}
 
//===----------------------------------------------------------------------===//
// TraceStartConfigOp
//===----------------------------------------------------------------------===//
 
LogicalResult TraceStartConfigOp::verify() {
  // Verify that the referenced symbol exists
  // This will be checked more thoroughly during lowering
  auto symbolName = getTraceConfig();
  if (symbolName.empty()) {
    return emitOpError("trace config symbol name cannot be empty");
  }
 
  return success();
}